Skip to content

Update to BankTabNames#12625

Open
Psyda wants to merge 5 commits into
runelite:masterfrom
Psyda:Psyda-patch-1
Open

Update to BankTabNames#12625
Psyda wants to merge 5 commits into
runelite:masterfrom
Psyda:Psyda-patch-1

Conversation

@Psyda

@Psyda Psyda commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Reopening #11105

It has been reviewed here: #11105, but I was unavailable for the last month to provide an update. Sorry for the delay, work has been rough, and the changes were implemented.

I removed the images I didn't create, so it now only includes my work. I also swappedthe awt.Desktop usage.


This replaces the single-icon sprite editor with a multi-icon system and overhauls how tab overlays are rendered.

Why: The old editor had a persistent issue where sprite IDs shuffled whenever the icon list updated, breaking user configs. The rendering was also clipped to the tab bar boundaries, limiting what users could do with custom icons and offsets. Both problems required a ground-up rethink rather than incremental patches .I held off on shipping incremental fixes because most of the reported problems shared root causes in the rendering and sprite ID systems. Fixing them properly meant reworking both at the same time.

What changed:
Tabs now support multiple icons (items, skills, game sprites, custom PNGs) with per-icon size, offset, z-index, and aspect-ratio-locked resizing. Icons and text render on Bankmain.INFINITE instead of Bankmain.TABS, removing the clipping limitation. Game sprite dimensions are resolved from SpritePixels.getMaxWidth/getMaxHeight rather than the trimmed BufferedImage from SpriteManager.getSprite(), which was causing sprites to render at wrong sizes.

The side panel got a scrollable icon editor, curated sprite category browser, fit toggle for stacking/overlay designs, config presets with import/export (versioned JSON), and panel visibility options.

See the updated README for full feature documentation.

Testing: Tested across all three tab display modes (item, digit, roman numeral), with bank settings page open/closed, with 1-8+ icons per tab, with custom user PNGs, and with various game sprites including non-square and padded sprites. Config migration from old single-icon format verified.

image image image

@runelite-github-app

runelite-github-app Bot commented Jun 15, 2026

Copy link
Copy Markdown

@Psyda Psyda changed the title Psyda patch 1 Update to BankTabNames Jun 15, 2026
Swapped missed awt.desktop usage to Runelite's LinkBrowser
@ldavid432

Copy link
Copy Markdown
Contributor

You need to add build=standard to your runelite-plugin.properties

@ldavid432 ldavid432 added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 16, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jun 16, 2026
@Psyda

Psyda commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

You need to add build=standard to your runelite-plugin.properties

I've added build=standard to the runelite-plugin.properties

@runelite-github-app

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants